Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readme for JS SDK #46

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Fix readme for JS SDK #46

merged 1 commit into from
Jul 12, 2024

Conversation

lmuntaner
Copy link
Collaborator

Motivation

Readme for the JavaScript SDK mentioned some parameters as optional but are mandatory.

Changes

  • Edit README.md in js-library.

Tests

Not necessary.

Todos

  • Add entry to changelog (if necessary). Not necessary.

@lmuntaner lmuntaner requested a review from a team as a code owner July 12, 2024 09:36
frederikrothenberger
frederikrothenberger approved these changes Jul 12, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmuntaner lmuntaner merged commit a116a2e into main Jul 12, 2024
8 checks passed
@lmuntaner lmuntaner deleted the lm-fix-readme-js-sdk branch July 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger