Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not publish to npm if no changes #41

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Do not publish to npm if no changes #41

merged 3 commits into from
Jul 1, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Jul 1, 2024 •
edited
Loading

Motivation

Avod publishing @dfinity/verifiable-credentials if there were no changes in the library.

Changes

  • New script publish-npm.sh.
  • Use the new script in workflow publish.
  • Add npm pack tarball extension to gitignore.

Tests

Tested manually.

Todos

  • Add entry to changelog (if necessary).

@lmuntaner lmuntaner requested a review from a team as a code owner July 1, 2024 08:10
@lmuntaner lmuntaner force-pushed the lm-do-not-publish-npm-if-no-changes branch from d9ba53d to c6ba2e4 Compare July 1, 2024 08:11
frederikrothenberger
frederikrothenberger approved these changes Jul 1, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmuntaner lmuntaner merged commit bbe5181 into main Jul 1, 2024
8 checks passed
@lmuntaner lmuntaner deleted the lm-do-not-publish-npm-if-no-changes branch July 1, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger