Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests to cover current functionality #4

Merged
merged 5 commits into from
Apr 25, 2024
Merged

Add more tests to cover current functionality #4

merged 5 commits into from
Apr 25, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Apr 24, 2024 •
edited
Loading

Motivation

We want the current functionality tested.

Changes

  • Add a function to reset the flow id. This will change because we should use UUIDs but we need it until we move to UUIDs.
  • Improve error message reporting.

Tests

  • Add seven more passing tests plus three skipped to be implemented in the upcoming functionality.

@lmuntaner lmuntaner marked this pull request as ready for review April 24, 2024 12:36
frederikrothenberger
frederikrothenberger approved these changes Apr 25, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

js-library/src/tests/request-verifiable-presentation.spec.ts Outdated Show resolved Hide resolved
js-library/src/tests/request-verifiable-presentation.spec.ts Show resolved Hide resolved
@lmuntaner lmuntaner merged commit fc123a7 into main Apr 25, 2024
6 checks passed
@lmuntaner lmuntaner deleted the lm-more-tests branch April 25, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

@peterpeterparker peterpeterparker Awaiting requested review from peterpeterparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger