Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummy Relying Party: Remove error after successful credential #31

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Dummy Relying Party: Remove error after successful credential #31

merged 1 commit into from
Jun 12, 2024

Conversation

lmuntaner
Copy link
Collaborator

Motivation

The error message of requesting credentials was present after receiving a successful credential.

This is because the error container wasn't cleaned. This is why the mindset State -> UI is better than pure dom manipulation 😂

Changes

  • Clean up the error container when successfule credential is rendered.

Tests

Tested manually.

Todos

  • Add entry to changelog (if necessary). NOT NECESSARY

frederikrothenberger
frederikrothenberger approved these changes Jun 12, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lmuntaner lmuntaner merged commit fdaf8a8 into main Jun 12, 2024
8 checks passed
@lmuntaner lmuntaner deleted the lm-remove-error-on-success branch June 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger