Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cargo test dummy_issuer to CI #25

Merged
merged 6 commits into from
Jun 10, 2024
Merged

Add cargo test dummy_issuer to CI #25

merged 6 commits into from
Jun 10, 2024

Conversation

lmuntaner
Copy link
Collaborator

Motivation

Do not add breaking changes to dummy_issuer accidentally.

In this PR, I add the integration tests of the dummy_issuer to the CI.

Changes

  • New workflow "Rust" to build the wasm and execute the tests.

Tests

Already running in the PR.

Todos

  • Add entry to changelog (if necessary). Not necessary.

@lmuntaner lmuntaner marked this pull request as ready for review June 10, 2024 09:56
@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger please review

frederikrothenberger
frederikrothenberger approved these changes Jun 10, 2024
View reviewed changes
Copy link

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename the CI pipeline for the relying party? It's now called "CI Checks" but is only one of four pipelines...

.github/workflows/rust.yml Outdated Show resolved Hide resolved
@lmuntaner lmuntaner merged commit bba263f into main Jun 10, 2024
8 checks passed
@lmuntaner lmuntaner deleted the lm-add-cargo-test-ui branch June 10, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger