Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remap new domain to old domain in expected origin for id alias (#68)
# Motivation II uses the old domain `ic0.app` to derive the principals even when the dapp is hosted in the new domain `icp0.io`. This happens in the `remapToLegacyDomain` helper in II. Therefore, the origin of the id alias credential uses the old domain `ic0.app` even though the dapp is hosted in the new domain `icp0.io`. Instead of requiring the developers to understand and know about this implementation detail, we decided to map the new domain of the expected origin to the old domain before comparing them. # Changes * New helper `remap_to_legacy_domain`. * Use new helper when comparing domains. # Tests * Add tests for the helper. * Add a test where the expected origin uses the new domain. # Todos - [ ] Add entry to changelog (if necessary). NOT NECESSARY.
- Loading branch information