Skip to content

Commit

Permalink
build: remove node-fetch (#45)
Browse files Browse the repository at this point in the history
# Motivation

Fetch API is supported in NodeJS since v18 and stable since v21. Given
that the engine is set to v20 here and given what we are doing, as think
it's probably fine to remove the `node-fetch` (we can run a "next" CI
job to double check).

Update: Job worked out
https://github.com/dfinity/verifiable-credentials-sdk/actions/runs/9869137332/job/27252340286
  • Loading branch information
peterpeterparker authored Jul 10, 2024
1 parent 4ad7bca commit 5ca3b96
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 93 deletions.
91 changes: 0 additions & 91 deletions js-library/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion js-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@
"eslint-config-standard": "^17.1.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-promise": "^6.1.1",
"node-fetch": "^3.3.2",
"prettier": "^3.2.5",
"prettier-plugin-organize-imports": "^3.2.4",
"typescript": "^5.4.5",
Expand Down
1 change: 0 additions & 1 deletion js-library/scripts/update-version.mjs
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { existsSync, readFileSync, writeFileSync } from "fs";
import fetch from "node-fetch";
import { join } from "path";

// The suffix we use to publish to npm wip version of the libs
Expand Down

0 comments on commit 5ca3b96

Please sign in to comment.