feat: parenthetical syntax for cycles etc.
#4608
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
commented
Jul 10, 2024
| @@ -312,14 +312,16 @@ let funcE name sort ctrl typ_binds args typs exp = | |||
| note = Note.{ def with typ; eff = T.Triv }; | |||
| } | |||
|
|
|||
| let recordE' = ref (fun _ -> nullE ()) (* gets correctly filled below *) | |||
There was a problem hiding this comment.
use and to allow mutual recursion
ggreif
commented
Jul 10, 2024
src/ir_passes/tailcall.ml
Outdated
| begin match e1.it, env with | ||
| | VarE f1, { tail_pos = true; | ||
| info = Some { func; typ_binds; temps; label; tail_called } } | ||
| when f1 = func && are_generic_insts typ_binds insts -> | ||
| tail_called := true; | ||
| (blockE (assignEs temps (exp env e2)) (breakE label (unitE ()))).it | ||
| | _,_-> PrimE (CallPrim insts, [exp env e1; exp env e2]) | ||
| | _,_-> PrimE (CallPrim (insts, pars), [exp env e1; exp env e2]) |
There was a problem hiding this comment.
Suggested change
| | _,_-> PrimE (CallPrim (insts, pars), [exp env e1; exp env e2]) | |
| | _,_-> PrimE (CallPrim (insts, exp env pars), [exp env e1; exp env e2]) |
ggreif
commented
Jul 10, 2024
unfortunately it doesn't arrive in the `async.ml`
at least now I get > ingress Err: IC0504: Canister rwlgt-iiaaa-aaaaa-aaaaa-cai violated contract: ic0_call_cycles_add128 called when no call is under construction.
we should use the system call though, instead of assigning to `@cycles`, as that will go away
ggreif
changed the title
cycles etc.
it crashes the compiler but other type of metadata could be useful here
not completely sure
tryin' my best…
rvanasa
reviewed
Oct 28, 2024
| @@ -214,6 +214,7 @@ | |||
| 'break' <id> <exp_nullary>? | |||
| 'continue' <id> | |||
| 'debug' <exp_nest> | |||
| '(' <exp_post>? 'with' <list(<exp_field>, ';')> ')' <exp_nest> | |||
There was a problem hiding this comment.
Thoughts on using , here in place of ; for consistency with other parenthesized expressions? The formatter uses this invariant (commas in parentheses, semicolons in square brackets and curly braces) to automatically replace commas with semicolons and vice versa whenever there is otherwise a syntax error that makes the AST unparseable. I can add an exception, but it seems nice to keep this pattern so that it's easier for people to remember which delimiter to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICCallPrim(and friends) should carry the fragment to set theSystemCyclesAddPrimwhile the call is being set up towards the replica.Parentheticals
(with cycles = 42_000_000) Actor.call(param)(with timeout = 10)ic0.call_with_best_effort_response : (timeout_seconds : i32) -> ()(with receiveMax = 50_000)(to limit the response size)(with resend = true; resendDelay = 3)whenSYS_TRANSIENTreject response (like UnixEINTR)call_cycles_add128_up_toic#1158(with memoryLimit = 1G) ActorClass(<args>)TODOs:
cycles : Natfor canister sends (self and raw sends too)asyncblocksICCallPrim, see topICCallRawPrim, not directly annotatable (desisting for now)FIXMEs,TODOs