Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iframe webauthn postmessage #2825
base: main
Are you sure you want to change the base?
Iframe webauthn postmessage #2825
Changes from 1 commit
cba26f9
1983e64
59ba3ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning
Code scanning / CodeQL
Missing origin verification in `postMessage` handler Medium
Copilot Autofix AI about 3 hours ago
To fix the problem, we need to verify the origin of incoming messages in the
postMessage
handler. This involves checking theevent.origin
property against a list of trusted origins before processing the message. If the origin is not trusted, the message should be ignored.The best way to fix the problem without changing existing functionality is to add an origin check at the beginning of the
postMessage
handler. We will define a list of trusted origins and compare theevent.origin
against this list. If the origin is trusted, we proceed with the existing logic; otherwise, we ignore the message.