Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: more complex input queues scenario for queue compatibility tests #745

Merged
merged 12 commits into from
Aug 7, 2024
Merged

test: more complex input queues scenario for queue compatibility tests #745

merged 12 commits into from
Aug 7, 2024

Conversation

oggy-dfin
Copy link
Member

Add a more exhaustive test to check that the visible behavior of canister input queues stays stable, in particular:

  1. that we pick input messages in a round-robin fashion over the different queue types
  2. that we successfully drain all messages from input queues

@github-actions github-actions bot added the test label Aug 5, 2024
@oggy-dfin oggy-dfin marked this pull request as ready for review August 5, 2024 14:06
@oggy-dfin oggy-dfin requested review from a team as code owners August 5, 2024 14:06
alin-at-dfinity
alin-at-dfinity approved these changes Aug 6, 2024
View reviewed changes
rs/types/base_types/src/principal_id.rs Outdated Show resolved Hide resolved
rs/replicated_state/src/canister_state/queues/tests.rs Outdated Show resolved Hide resolved
rs/tests/message_routing/queues_compatibility_test.rs Outdated Show resolved Hide resolved
@oggy-dfin oggy-dfin added this pull request to the merge queue Aug 7, 2024
Merged via the queue into master with commit d5511c9 Aug 7, 2024
23 checks passed
@oggy-dfin oggy-dfin deleted the oggy-queue-input-iterator-compatibility-tests branch August 7, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wong-dfinity-org daniel-wong-dfinity-org daniel-wong-dfinity-org approved these changes

@alin-at-dfinity alin-at-dfinity alin-at-dfinity approved these changes

@marko-k0 marko-k0 marko-k0 approved these changes

Assignees
No one assigned
Labels
@ic-interface-owners @ic-message-routing-owners @idx @nns-team test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oggy-dfin @marko-k0 @alin-at-dfinity @daniel-wong-dfinity-org