Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mocked xnet in PocketIC #3376

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

fix: mocked xnet in PocketIC #3376

wants to merge 11 commits into from
+201 −136

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Jan 9, 2025 •
edited
Loading

This PR fixes an assertion failure in the mocked xnet of PocketIC, reproduced in a new PocketIC test sending 500 inter-canister calls with ~10KB payloads:

2025-01-09T12:14:35.158543Z  INFO pocket_ic_server: The PocketIC server is listening on port 43473
thread 'tokio-runtime-worker' panicked at rs/xnet/payload_builder/src/lib.rs:862:25:
Slice from 6a7lo-edqtc-nflgn-rbyzy-msh45-ifbmo-xs5bc-p3l2c-my7nk-i47kz-gae has packed byte size 3995437, unpacked byte size 3984588, limit was 3984588

The fix proceeds by reusing the production XNetSlicePoolImpl and only mocking the code fetching XNet slices from remote subnets.

@github-actions github-actions bot added the fix label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alin-at-dfinity alin-at-dfinity alin-at-dfinity left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraszyk @alin-at-dfinity