Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ckbtc): Add account to discarded UTXOs #2762

Merged
merged 15 commits into from
Nov 28, 2024

Conversation

gregorydemay
Copy link
Member

@gregorydemay gregorydemay commented Nov 22, 2024

Follow-up on #2674 to add the ledger account to a UTXO that was discarded, either due to a value being too small to cover the KYT fee, or being marked as tainted.

Remarks:

  1. Add a new event type DiscardedUtxo that is used for both an ignored and quarantined UTXO and that contains the ledger account.
  2. All code paths were the ledger account was not needed to discard a UTXO are marked as deprecated. They cannot be removed to be able to replay past events.
  3. Added metrics related to the number of discarded UTXOs without ledger account since this should hopefully go to 0 and related to the number of ignored/quarantined UTXOs.
  4. CI_OVERRIDE_DIDC_CHECK: The Candid changes only affect the debug endpoint get_events.

@github-actions github-actions bot added the feat label Nov 22, 2024
@gregorydemay gregorydemay added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Nov 26, 2024
@gregorydemay gregorydemay marked this pull request as ready for review November 26, 2024 12:25
@gregorydemay gregorydemay requested a review from a team as a code owner November 26, 2024 12:25
@gregorydemay gregorydemay added the CI_OVERRIDE_DIDC_CHECK Skips the backwards compatibility didc check (explain in PR description why) label Nov 28, 2024
@gregorydemay gregorydemay added this pull request to the merge queue Nov 28, 2024
Merged via the queue into master with commit 6f1be0f Nov 28, 2024
24 checks passed
@gregorydemay gregorydemay deleted the gdemay/XC-230-add-account branch November 28, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 CI_OVERRIDE_DIDC_CHECK Skips the backwards compatibility didc check (explain in PR description why) @cross-chain-team feat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants