-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ckbtc): Add account to discarded UTXOs #2762
Merged
Merged
+575
−307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorydemay
added
the
CI_ALL_BAZEL_TARGETS
Runs all bazel targets and uploads them to S3
label
Nov 26, 2024
THLO
reviewed
Nov 27, 2024
THLO
reviewed
Nov 27, 2024
THLO
reviewed
Nov 27, 2024
THLO
reviewed
Nov 27, 2024
THLO
reviewed
Nov 27, 2024
Co-authored-by: Thomas Locher <[email protected]>
gregorydemay
added
the
CI_OVERRIDE_DIDC_CHECK
Skips the backwards compatibility didc check (explain in PR description why)
label
Nov 28, 2024
ninegua
approved these changes
Nov 28, 2024
THLO
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI_ALL_BAZEL_TARGETS
Runs all bazel targets and uploads them to S3
CI_OVERRIDE_DIDC_CHECK
Skips the backwards compatibility didc check (explain in PR description why)
@cross-chain-team
feat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #2674 to add the ledger account to a UTXO that was discarded, either due to a value being too small to cover the KYT fee, or being marked as tainted.
Remarks:
DiscardedUtxo
that is used for both an ignored and quarantined UTXO and that contains the ledger account.0
and related to the number of ignored/quarantined UTXOs.CI_OVERRIDE_DIDC_CHECK
: The Candid changes only affect the debug endpointget_events
.