chore(boundary): add candid error types and unit tests for rate-limit canister #2746
+1,414
−636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikolay-komarevskiy
force-pushed
the
komarevskiy/error-handling-unit-tests
branch
3 times, most recently
from
d6736d2
to
5d8ffb2
Compare
nikolay-komarevskiy
added
the
CI_OVERRIDE_DIDC_CHECK
nikolay-komarevskiy
force-pushed
the
komarevskiy/error-handling-unit-tests
branch
from
5d8ffb2
to
4d14857
Compare
nikolay-komarevskiy
changed the title
nikolay-komarevskiy
force-pushed
the
komarevskiy/error-handling-unit-tests
branch
from
4d14857
to
743b393
Compare
nikolay-komarevskiy
force-pushed
the
komarevskiy/error-handling-unit-tests
branch
from
ee99041
to
6b0a377
Compare
nikolay-komarevskiy
force-pushed
the
komarevskiy/error-handling-unit-tests
branch
from
6b0a377
to
fae7e53
Compare
|
|
||
| #[derive(CandidType, Deserialize, Debug, Clone)] | ||
| pub enum DiscloseRulesArg { | ||
| RuleIds(Vec<RuleId>), | ||
| IncidentIds(Vec<IncidentId>), | ||
| } | ||
|
|
||
| #[derive(CandidType, Debug, Deserialize)] | ||
| pub enum GetConfigError { |
There was a problem hiding this comment.
Do we really need all these errors separately? Maybe just combine in a single enum?
There was a problem hiding this comment.
GetRulesByIncidentIdError and GetRuleByIdError could indeed be combined to avoid some overhead, but GetConfigError has different variant. My rationale to keep errors separate was for better clarify and for potential forward compatibility. This would ensure we could more easily extend/modify candid errors in the future, if we need to.
There was a problem hiding this comment.
this was also a recommendation from the nns folks - better keep definitions separate and as flexible as possible for the potential future changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.