chore: remove upgrade_insecure_requests header in PocketIC gateway #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mraszyk
commented
Nov 14, 2024
Comment on lines
+622
to
+624
| http_response | ||
| .headers_mut() | ||
| .remove(UPGRADE_INSECURE_REQUESTS); |
There was a problem hiding this comment.
@adamspofford-dfinity Could you please suggest how the headers should be modified here?
There was a problem hiding this comment.
Upgrade-Insecure-Requestsshould not be blocked (or rather since it's a request header it shouldn't appear in the first place)Strict-Transport-Securityshould be blockedContent-Security-Policy, if it exists, should be modified to remove theupgrade-insecure-requests;directive, if it exists
There was a problem hiding this comment.
Modifying the content of the CSP header looks involved to me. I see the following alternatives:
- block CSP entirely for localhost (this would make local testing of CSP impossible though);
- modify the content of the CSP header when deploying an asset canister to the local network.
The latter seems to be the most robust option in my opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
upgrade_insecure_requestsheader in the PocketIC HTTP gateway if this gateways serves at http:// (context).