Use a single canister for many tests #8
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hansl reported issues with `ic-ref` when doing a heavy request (such as installing a large canister via a wallet canister): The subsequent `/api/v1/read` would not be handled, and eventually timed out. The fact that installing a large caniter via the wallet caniter is very slow is hard to fix while we use an interpreter (optimizing the candid library might help, though – the universal canister handles this use case fine, as the newly added test shows). But with some changes to the code (in `read`, do not try to read from an `MVar` that is blocked, and make sure that the processing after returning HTTP 202 happens in the background), the request status read would be handled, and `dfx` keeps polling as expected. Also added a `--http-log` option that prints some (not very helpful) HTTP logs. Originally https://github.com/dfinity-lab/ic-ref/commit/b0942527bfded26eacf6a1fca8ca77e708ba68fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that we save may canister installations. Oddly, does not speed things up; it
seems that the tests that cannot share the canister are the bottleneck.