Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to GHC-9.4 resulting in lower compile-time memory usage #148

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

basvandijk
Copy link
Contributor

@basvandijk basvandijk commented Feb 28, 2023

Building ic-hs with GHC-9.0 requires ~13GB of memory. Upgrading to GHC-9.4 reduces this by around 30% to ~9GB:

Screenshot 2023-02-28 at 17 20 14

mraszyk
mraszyk previously approved these changes Feb 28, 2023
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@ggreif
Copy link
Contributor

ggreif commented Mar 4, 2023

This is nice, but we need a coherent plan how to promote such changes downstream. E.g. dfinity/motoko will need the same GHC so that we can reuse the binary cache artefacts. Hopefully nix will take care of this.

@nomeata
Copy link
Contributor

nomeata commented Mar 4, 2023

I thought dfinity/motoko imports this repo as a whole, so for ic-ref-test it uses the same nixpkgs pin and thus the cache can be shared?

@ggreif
Copy link
Contributor

ggreif commented Mar 4, 2023

Hopefully. But we also have a majority of M1 Macs in the meantime which have to build locally. So that is one difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants