Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cli): streamline neuron balance execution #1227

Merged
merged 1 commit into from
Jan 20, 2025
Merged

refactor(cli): streamline neuron balance execution #1227

merged 1 commit into from
Jan 20, 2025

Conversation

sasa-tomic
Copy link
Member

@sasa-tomic sasa-tomic commented Jan 17, 2025 •
edited
Loading

Changes

  • Removed Neuron Override in Balance Command: Eliminated the unnecessary neuron_override field from the Balance struct.

@sasa-tomic
refactor(cli): simplify neuron balance command
32313b1 
### Removed
- Eliminate `neuron_override` option from `Balance` struct.

### Updated
- Simplify `require_auth` method to always require `AuthRequirement::Neuron`.
- Use `ctx.neuron_id()` to determine neuron ID, providing a fallback if none is specified.

### Added
- Introduce `neuron_id` method in `DreContext` to fetch neuron ID option.

### Note
- Updated related tests and comments to reflect these changes.
@sasa-tomic sasa-tomic requested a review from a team as a code owner January 17, 2025 19:03
@sasa-tomic sasa-tomic self-assigned this Jan 17, 2025
@sasa-tomic sasa-tomic merged commit 36d986c into main Jan 20, 2025
5 checks passed
@sasa-tomic sasa-tomic deleted the refactor/neuron-balance-command branch January 20, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

Assignees

@sasa-tomic sasa-tomic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sasa-tomic @NikolaMilosa