GDS radio button update #86
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you Rich! Sorry my comment wasn't very clear at all on the original issue - centre aligning the options (as in the text next to the buttons!) was what I'd meant - happy if the actual label text is left-aligned if this isn't too much of a pain to revert! This fix looks good though and in line with the gov.uk expectations, and fixes the issue we have with text being underneath the radio buttons and slightly out of line in the current version - however I can't replicate your output in the run_example - does it need any other arguments added to it? Still looks like this for me: 
|
|
I'm ditching this one due to misunderstanding what was being asked for. Seemed easier after that to start afresh on a separate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covering off the radio button label centre alignment for inline buttons in accordance with Issue #60.
Note that it centre aligns within the overall container and not to the width of the options, so requires careful use by anyone using inline as it is. The remit says to centre align the text, but maybe it makes more sense to centre align the options as well as the text when inline?