Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "warning" from appearing where it shouldn't #83

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

sarahmwong
Copy link
Collaborator

Overhang from old CSS and use of .govuk-warning-text__assistive which is no longer in CSS file. Printed out "Warning" in text after every warning message:
Screenshot 2024-06-05 at 15 48 59

Now uses govuk-visually-hidden - checked and this is a lift and shift of the old assistive text CSS, with a few more custom options for users added in (think this is to support different assistive setups)
Screenshot 2024-06-05 at 15 47 20

@sarahmwong sarahmwong requested a review from jenisayshi June 11, 2024 13:00
@sarahmwong sarahmwong merged commit 9049363 into update-to-gds-v5.4 Jun 17, 2024
5 checks passed
@sarahmwong sarahmwong deleted the warning_text branch June 17, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants