Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview of changes
Resolves #77, by adding an extra argument to the footer, allowing a vector of link text to be added, automatically generating actionLinks and IDs that can be used to control a hidden tabset.
Gone for this approach as I think it balances simplicity for the users with the functional need. As R Shiny is almost always a single page app, I assume most people would be using actionLinks to trigger a tabset shifting rather than actual href's to external pages. If we think this is a need, then I'll need to think again about the argument users can use. An alternative could be to allow users to put in any shiny tagList they deem appropriate, would be easier for us but then opens the door to more weird and wonderful stuff that might not be ideal or have the right styling.
Have added a functional example to the
run_example()
app too.PR Checklist
devtools::check()
Reviewer instructions
full = TRUE / FALSE
option? Having poke at it a bit, I can see difference in the output code, but can't work out the difference for an end user of a dashboard? If we don't, I could try to tidy that up in this PR too?