Testing out package installs on automated scripts #22
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| stage 5 (KS5)."), | ||
| p(actionLink("link_to_app_content_tab", "16-18 Transition Matrices tool")), | ||
| p(actionLink("link_to_app_content_tab", "16 to 18 Transition Matrices tool")), |
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 96 characters. Note
| @@ -60,8 +60,8 @@ | |||
| div( | |||
| class = "panel-body", | |||
| h3("Context and purpose"), | |||
| p("To use the 16-18 Transition Matrices tool click onto the 'Dashboard' tab found on the left panel. Please then | |||
| select a report year (the year students finished 16-18 study), qualification, subject and subject size from the dropdown boxes. | |||
| p("To use the 16 to 18 Transition Matrices tool click onto the 'Dashboard' tab found on the left panel. Please then | |||
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 131 characters. Note
| p("To use the 16-18 Transition Matrices tool click onto the 'Dashboard' tab found on the left panel. Please then | ||
| select a report year (the year students finished 16-18 study), qualification, subject and subject size from the dropdown boxes. | ||
| p("To use the 16 to 18 Transition Matrices tool click onto the 'Dashboard' tab found on the left panel. Please then | ||
| select a report year (the year students finished 16 to 18 study), qualification, subject and subject size from the dropdown boxes. |
Check notice
Code scanning / lintr
Lines should not be more than 80 characters. This line is 146 characters. Note
| @@ -120,7 +120,7 @@ | |||
| gov_row( | |||
| column( | |||
| width = 12, | |||
| h1("16-18 Transition Matrices"), | |||
| h1("16 to 18 Transition Matrices"), | |||
Check warning
Code scanning / lintr
no visible global function definition for 'h1' Warning
I've done some manual fixing on getting odbc (and callr / processx) running. Not sure what's going on with all of these, but the lintr test is running now and I've applied the same fixes to the deploy script.
One quick minor switch as well is around accessibility, which is to swap out "16-18" for "16 to 18" as that's going to be clearer for screen reader users.