Replaced all tags links in support panel with dfeshiny::external_link() #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjrace
requested changes
Sep 30, 2024
cjrace
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of changes
We'd added the
external_link()function previously, but not applied it insupport_panel(). I've done a quick update to change the links in the support panel to use external_link.Why are these changes being made?
We want to be internally consistent in using our own advice!
Detailed description of changes
There were several
tags$a()instances in support links. I've updated all of these toexternal_link()and removed the warning for the ones that are mailto links to e-mail addresses.Connected issues
Resolves #50