Latest development merge #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a flag from passes everything test
Adding Local skills improvement plan area as a geographic level
cjrace
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one mainly brings in the LSIP as a geographic level into the live screener.
Just done a few bits of additional clean-up around packages as the app was crashing on start-up on the dev server. Think it was a variant on the png package issues on the server. This time, the app was trying to load the shinytest package, which was then falling over when it couldn't find a library that png should be linked in to. I've removed shinytest from the library calls in the app as it wasn't really needed there anyway I don't think. run_tests_locally() uses shinytest:: as a call directly when calling the shinytest run test function, so seems to work fine without the library load.