Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24 25 code updates #99

Merged
merged 7 commits into from
Sep 26, 2024
Merged

24 25 code updates #99

merged 7 commits into from
Sep 26, 2024

Conversation

c-h-rowe
Copy link
Contributor

@c-h-rowe c-h-rowe commented Sep 26, 2024

Pull request overview

Give a general description of why a change is being made, include issue number(s) being fixed if relevant

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Dashboard displays data for end of 2023/24 academic year.

What is the new behaviour?

Dashboard displays data for week commencing 9 September 2024, first of 2024/25 academic year

@c-h-rowe c-h-rowe requested a review from tom-curd September 26, 2024 08:12
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lintr found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@c-h-rowe c-h-rowe merged commit 40899b3 into main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants