Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data updated for 7th Nov publication #103

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Data updated for 7th Nov publication #103

merged 3 commits into from
Nov 7, 2024

Conversation

t-surtees
Copy link
Contributor

Pull request overview

Updates to data and dates in the dashboard.

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

7th Nov publication, some schools on half term meaning dates at LA level in the dashboard differ.

What is the new behaviour?

Data updated, dates in dashboard changed to use manually inputted dates given fortnights don't match up at LA level due to half term.

Anything else

Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

@t-surtees t-surtees requested a review from c-h-rowe November 7, 2024 09:12
c-h-rowe
c-h-rowe approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@c-h-rowe c-h-rowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for publication on 7/11/2024

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 7, 2024
View reviewed changes
server.R
@@ -1480,8 +1480,8 @@
most_recent_fullweek_date <- live_attendance_data_weekly() %>%
pull(week_commencing)

paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data on this tab relates to the week commencing 2023-12-11.")
# paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
@@ -1480,8 +1480,8 @@
most_recent_fullweek_date <- live_attendance_data_weekly() %>%
pull(week_commencing)

paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data on this tab relates to the week commencing 2023-12-11.")
# paste0("Data on this tab relates to the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 96 characters. Note

Lines should not be more than 80 characters. This line is 96 characters.
server.R
@@ -1503,8 +1503,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 204 characters. Note

Lines should not be more than 80 characters. This line is 204 characters.
server.R
# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 211 characters. Note

Lines should not be more than 80 characters. This line is 211 characters.
server.R
# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 211 characters. Note

Lines should not be more than 80 characters. This line is 211 characters.
server.R
@@ -1553,8 +1553,8 @@
as.Date(attendance_date) + 31
# as.Date(attendance_date) + 38

# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 204 characters. Note

Lines should not be more than 80 characters. This line is 204 characters.
server.R
# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.
server.R
# paste0("Data was last updated on 2024-06-13 and is next expected to be updated on 2024-06-27. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")
paste0("Data was last updated on 2024-11-07 and is next expected to be updated on 2024-11-21. The latest full week of data for this breakdown was the week commencing ", most_recent_fullweek_date, ".")
# paste0("Data was last updated on ", last_update_date, " and is next expected to be updated on ", next_update_date, ". The latest full week of data was the week commencing ", most_recent_fullweek_date, ".")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 211 characters. Note

Lines should not be more than 80 characters. This line is 211 characters.
@t-surtees t-surtees requested a review from c-h-rowe November 7, 2024 09:59
c-h-rowe
c-h-rowe approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@c-h-rowe c-h-rowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for 7 Nov 2024 publication

@t-surtees t-surtees merged commit 2ced693 into main Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-h-rowe c-h-rowe c-h-rowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t-surtees @c-h-rowe