Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dashboard with data for 10th Oct publication #100

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

t-surtees
Copy link
Contributor

Pull request overview

Updated data, slight changes to dashboard wording.

Pull request checklist

Please check if your PR fulfils the following:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been run locally and are passing (run_tests_locally())
  • Code is styled according to tidyverse styling (checked locally with tidy_code())

What is the current behaviour?

Updating data for publication.

What is the new behaviour?

New data, slight change to dashboard wording.

Anything else

Add any notes for people reviewing and testing your code that are appropriate. Tag a @person to review if someone in particular needs to see this.

@t-surtees t-surtees requested a review from tom-curd October 10, 2024 08:11
server.R Dismissed Show dismissed Hide dismissed
@@ -1096,7 +1096,7 @@
mutate(proportion_schools_count = (num_schools / total_num_schools) * 100)

# paste0("For this breakdown, in the week prior to half term there were ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of schools opted-in, though this has varied throughout the year-to-date. This figure is not shown for the latest week due to half-term impacting upon number of schools reporting.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the 19 August 2024 it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the start of the 2024/25 academic year, it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")

Check warning

Code scanning / lintr

no visible global function definition for '%>%' Warning

no visible global function definition for '%>%'
@@ -1096,7 +1096,7 @@
mutate(proportion_schools_count = (num_schools / total_num_schools) * 100)

# paste0("For this breakdown, in the week prior to half term there were ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of schools opted-in, though this has varied throughout the year-to-date. This figure is not shown for the latest week due to half-term impacting upon number of schools reporting.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the 19 August 2024 it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the start of the 2024/25 academic year, it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")

Check warning

Code scanning / lintr

no visible global function definition for '%>%' Warning

no visible global function definition for '%>%'
@@ -1096,7 +1096,7 @@
mutate(proportion_schools_count = (num_schools / total_num_schools) * 100)

# paste0("For this breakdown, in the week prior to half term there were ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of schools opted-in, though this has varied throughout the year-to-date. This figure is not shown for the latest week due to half-term impacting upon number of schools reporting.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the 19 August 2024 it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the start of the 2024/25 academic year, it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")

Check warning

Code scanning / lintr

no visible global function definition for 'pull' Warning

no visible global function definition for 'pull'
@@ -1096,7 +1096,7 @@
mutate(proportion_schools_count = (num_schools / total_num_schools) * 100)

# paste0("For this breakdown, in the week prior to half term there were ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of schools opted-in, though this has varied throughout the year-to-date. This figure is not shown for the latest week due to half-term impacting upon number of schools reporting.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the 19 August 2024 it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the start of the 2024/25 academic year, it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")

Check warning

Code scanning / lintr

no visible binding for global variable 'proportion_schools_count' Warning

no visible binding for global variable 'proportion_schools_count'
@@ -1096,7 +1096,7 @@
mutate(proportion_schools_count = (num_schools / total_num_schools) * 100)

# paste0("For this breakdown, in the week prior to half term there were ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of schools opted-in, though this has varied throughout the year-to-date. This figure is not shown for the latest week due to half-term impacting upon number of schools reporting.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the 19 August 2024 it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")
paste0("This number is approximately ", count_prop_week %>% pull(proportion_schools_count) %>% mean(na.rm = TRUE) %>% round(digits = 0), "% of the number of schools participating in the School Census. From the start of the 2024/25 academic year, it became mandatory for schools to share attendance data with the DfE. As more schools share their data, the number of schools reporting may change over time.")

Check notice

Code scanning / lintr

Lines should not be more than 80 characters. This line is 410 characters. Note

Lines should not be more than 80 characters. This line is 410 characters.
@tom-curd tom-curd merged commit f79b7eb into main Oct 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants