New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page 1 add reactive dropdown #84

Open

cjrace wants to merge 12 commits into main from page-1-add-reactive-dropdown

Contributor

cjrace commented Oct 15, 2024

Pull request overview

Attempt to add a region dropdown onto the first page and then make the chart and table selections update that... Not ready to review yet as still very much a work in progress, will pick this up again later in the week.

Pull request checklist

Please check if your PR fulfills the following:

Tests for the changes have been added (for bug fixes / features)
Docs have been reviewed and added / updated if needed (for bug fixes / features)
Tests have been run locally and are passing (shinytest2::test_app())
Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

...

What is the new behaviour?

...

Anything else

...

cjrace added 4 commits

October 15, 2024 16:58


          WIP - added dropdown but not connected properly

bb494b7


          WIP - added dropdown but not connected properly


          regenerate manifest

e68d509

Merge branch 'page-1-add-reactive-dropdown' of https://github.com/dfe-analytical-services/apprenticeships-provider-dashboard into page-1-add-reactive-dropdown

# Conflicts:
#	manifest.json


          Still WIP - not yet connected the dropdown fully. Left todo markers f…

a140f1e

…or next steps

cjrace self-assigned this

github-advanced-security bot found potential problems

View reviewed changes

R/dashboard_modules/01-provider_breakdowns.R Outdated

-                      delivery_region_table <- delivery_region_table %>% filter(learner_home_region == selected_learner_home_region())
+                    # # Filter to learner home region selection if it exists
+                    # if (length(selected_learner_home_region()) == 1) {
+                    #   delivery_region_table <- delivery_region_table %>% filter(learner_home_region == selected_learner_home_region())

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

R/dashboard_modules/01-provider_breakdowns.R Outdated

-                      delivery_region_table <- delivery_region_table %>% filter(learner_home_region == selected_learner_home_region())
+                    # # Filter to learner home region selection if it exists
+                    # if (length(selected_learner_home_region()) == 1) {
+                    #   delivery_region_table <- delivery_region_table %>% filter(learner_home_region == selected_learner_home_region())

Check notice

Code scanning / lintr

Lines should not be more than 120 characters. This line is 122 characters. Note

Lines should not be more than 120 characters. This line is 122 characters.

R/dashboard_modules/01-provider_breakdowns.R Outdated

-                      home_region_table <- home_region_table %>% filter(delivery_region == selected_delivery_region())
+                    # # Filter to delivery region selection if it exists
+                    # if (length(selected_delivery_region()) == 1) {
+                    #   home_region_table <- home_region_table %>% filter(delivery_region == selected_delivery_region())

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

R/dashboard_modules/01-provider_breakdowns.R Outdated

-                  })
+                  # TODO: Make this work
+                  # observe({
+                  #   print(input$regions_bar_selected)

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

R/dashboard_modules/01-provider_breakdowns.R Outdated

+                  #   if (length(input$regions_bar_selected) != 0) {
+                  #     if(input$regions_bar_selected != "All regions"){
+                  #       updateSelectizeInput(
+                  #         session = session,

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

R/dashboard_modules/01-provider_breakdowns.R Outdated

+                  #     if(input$regions_bar_selected != "All regions"){
+                  #       updateSelectizeInput(
+                  #         session = session,
+                  #         inputId = "region",

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

R/dashboard_modules/01-provider_breakdowns.R Outdated

+                  #       updateSelectizeInput(
+                  #         session = session,
+                  #         inputId = "region",
+                  #         selected = input$regions_bar_selected,

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

R/dashboard_modules/01-provider_breakdowns.R Outdated

+                  #         session = session,
+                  #         inputId = "region",
+                  #         selected = input$regions_bar_selected,
+                  #         server = TRUE

Check notice

Code scanning / lintr

Commented code should be removed. Note

Commented code should be removed.

axcooper self-requested a review

October 24, 2024 11:59

axcooper marked this pull request as ready for review

November 5, 2024 12:07

axcooper requested a review from johalastrahol

November 5, 2024 12:17

axcooper added 2 commits

November 28, 2024 18:38


          region dropdwon now observes and is updated by selecting a region bar…

578fd8e

… in the chart


          removed commented out code

c82e494

johalastrahol approved these changes

View reviewed changes

Contributor

johalastrahol left a comment

All looks fine now. Region bar highlighted as expected

johalastrahol approved these changes

View reviewed changes

axcooper added 6 commits

November 29, 2024 15:08


          working on region bars

eaebbf1


          better punctuation than underscore in region dropdown

8fba7f4


          fixed typo

8a091d6


          removed some commented out ocde

58a4d1a


          made dropdowns go along top

3f1d5aa


          working on updating region / home table from region dropdown

15b8adb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet