59 - page 2 map improvements

[cjrace]

Pull request overview

Updated the maps / page 2 in a few different ways to make them a bit neater for users. Resolves #56, resolves #57, resolves #58, resolves #59, resolves #61.

Pull request checklist

Please check if your PR fulfills the following:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Tests have been run locally and are passing (shinytest2::test_app())
• Code is styled according to tidyverse styling (checked locally with styler::style_dir() and lintr::lint_dir())

What is the current behaviour?

Currently:

• Clicking on maps doesn't do anything
• Some 0's are showing
• Maps are too small
• There's a big gap to the tables pagination on the tables tab
• There's no way to reset the map if you've dragged it around
• Maps / tables will just error if there's no rows for the selections

What is the new behaviour?

• Selecting an LAD from a map, triggers an LAD selection

• No 0's show on maps

• Maps have a reset button
  

• Maps look a little neater - are larger in the space, have stronger blues
  7

• The gap for tables has been removed
  

• Custom error message added for when there are no rows of data available for the selections made
  

Anything else

I also renamed dfe_map() to dfe_lad_map() as I realised the function I'd made was LAD specific so felt that made more sense and would prevent confusion if trying to reuse it for any other levels.

Tests are failing, though that's expected because the fixes for them are still in #70.

[axcooper]

The map being selectable is a huge improvement, and the zeros being filtered out, resizing and better colours really help too. I am not able to get the reset button to work though?

[axcooper]

Think it would be even better if could select a provider using the table too?

[cjrace]

The map being selectable is a huge improvement, and the zeros being filtered out, resizing and better colours really help too. I am not able to get the reset button to work though?

The reset button resets the zoom / focus if you move it about, though currently doesn't reset any LAD selection - is that what you're expecting to happen? (I've not done it before, but think that's possible to add if so)

Can look at adding the provider selection from the table too, probably in place of the current dropdown and then just having a search on the table like we do on a couple of the other tabs, won't get to it today but will add next week

[axcooper]

I was expecting the reset button to undo any LAD selection, if that is possible, that would be a great addition.

[cjrace]

I've made the reset button clear the dropdown input as well, takes a fraction of a second longer than I'd like but works well. Should be ready for you to test again @axcooper.

I have created #82 as a separate issue for making the table selectable, as I think it's probably best to cover that as a separate piece of work. Thinking of the time we have left and the value gained from doing it, as currently a user can do everything I think they needs, you have the dropdown for selecting or searching for the provider. Also thinking actually, it might be a nice test case to do some A / B testing to get some user feedback on a selectable table versus a dropdown search, which could then build evidence for why putting the extra effort in to make it selectable is worthwhile.

[axcooper]

It's great that the reset button removes the selected LAD, I know what you mean about it taking longer than hoped, but it's still a great addition

[axcooper]

Happy that the reset button works to clear the selected LAD