Implement shulker boxes #956
Draft
+431
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented inventory Implemented sounds Implemented opening/closing animations
Hope it doesn't break anything else
89 tasks
DaPigGuy
reviewed
Dec 15, 2024
| @@ -254,7 +254,7 @@ func (s *Session) invByID(id int32, tx *world.Tx) (*inventory.Inventory, bool) { | |||
| return nil, false | |||
| } | |||
| switch id { | |||
| case protocol.ContainerLevelEntity: | |||
| case protocol.ContainerLevelEntity, protocol.ContainerShulkerBox: | |||
There was a problem hiding this comment.
This should validate that the shulker box actually exists, as is the case with other container block inventories.
|
|
||
| // ShulkerBox is a dye-able block that stores items. Unlike other blocks, it keeps its contents when broken. | ||
| type ShulkerBox struct { | ||
| solid // TODO: I don't think it should be solid |
|
|
||
| // BreakInfo ... | ||
| func (s ShulkerBox) BreakInfo() BreakInfo { | ||
| return newBreakInfo(2, alwaysHarvestable, pickaxeEffective, oneOf(s)).withBlastResistance(10) |
There was a problem hiding this comment.
Suggested change
| return newBreakInfo(2, alwaysHarvestable, pickaxeEffective, oneOf(s)).withBlastResistance(10) | |
| return newBreakInfo(2, alwaysHarvestable, pickaxeEffective, oneOf(s)) |
Not needed if blast resistance = hardness * 5
| @@ -0,0 +1,205 @@ | |||
| package block | |||
|
|
|||
| // ShulkerBoxType represents a type of shulker box. | |||
There was a problem hiding this comment.
It would be nice if we could avoid this. Candles & bundles will also have a no color option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fully implement shulker boxes.
Only one thing needs to be addressed: