implement beds , respawn anchors #938
Conversation
server/world/tick.go
Outdated
| t.w.set.RequiredSleepTicks-- | ||
| if t.w.set.RequiredSleepTicks-1 <= 0 { |
There was a problem hiding this comment.
Is this logic correct? You're decrementing the ticks and then checking if the tick below is <= 0?
server/block/bed.go
Outdated
| // SpawnBlock represents a block using which player can set his spawn point. | ||
| type SpawnBlock interface { | ||
| SpawnBlock() bool | ||
| Update(pos cube.Pos, u item.User, w *world.World) | ||
| } |
There was a problem hiding this comment.
Please use proper grammer in the docs and also document the methods of the interface. Update is a very ambiguous name and doesn't hint towards being related to spawn points
There was a problem hiding this comment.
You have changed the method name but the documentation is still needing to be updated
There was a problem hiding this comment.
I have had another look, there are still unresolved comments that I have previously provided. I am not going to review this PR anymore until every single comment has been acted on or you've replied with a valid counter argument. I have gone through and resolved all the comments you have addressed but there are still many that remain
| for _, d := range cube.Directions() { | ||
| beds = append(beds, Bed{Facing: d}) | ||
| beds = append(beds, Bed{Facing: d, Head: true}) | ||
| } |
There was a problem hiding this comment.
Not having the occupied block states registered might be problematic?
There was a problem hiding this comment.
I think the problem is that colored versions were not taken into account?
There was a problem hiding this comment.
Bed color is set through the tile, not a block state. Please undo your change.
If all beds are white in the creative inventory, it is probably the same issue with the creative item entries missing NBT that banners have. See a1c98da
|
Please fix merge conflicts |
bro , I'm dead ☠️ |
# Conflicts: # server/player/handler.go # server/player/player.go # server/session/session.go # server/world/tick.go # server/world/world.go
server/block/bed.go
Outdated
| if !ok { | ||
| return | ||
| } | ||
| headSide.Sleeper.Wake() |
There was a problem hiding this comment.
Need to check if Sleeper is nil before calling Wake() to avoid a nil pointer.
| headSide.Sleeper.Wake() | |
| sleeper := headSide.Sleeper | |
| if sleeper != nil { | |
| sleeper.Wake() | |
| } |
No description provided.