Add groupsClaimMapping to the OIDC connector #1776
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The groupsClaimMapping setting allows one to specify which claim to pull group information from the OIDC provider. Previously it assumed group information was always in the "groups" claim, but that isn't the case for many OIDC providers (such as AWS Cognito using the "cognito:groups" claim instead) Signed-off-by: Scott Lemmon <[email protected]>
Lemmons
force-pushed
the
oidc-group-claims-mapping
branch
from
9c64a9a to
bdd56f8
Compare
|
This is related to #1065 |
|
Looks like #1631 implemented this same logic back in Jan, but is still waiting for a review. |
|
I'm fine with resubmitting it. Please see #1777 before reviewing and merging this. |
xtremerui
pushed a commit
to concourse/dex
that referenced
this pull request
Aug 11, 2020
add tests for groups key mapping Signed-off-by: Rui Yang <[email protected]>
|
Fixed in #1634 |
elffjs
pushed a commit
to DIMO-Network/dex
that referenced
this pull request
Jun 27, 2022
add tests for groups key mapping Signed-off-by: Rui Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
groupsClaimMappingsetting allows one to specify which claim to pull group information from the OIDC provider. Previously it assumed group information was always in the "groups" claim, but that isn't the case for many OIDC providers (such as AWS Cognito using the "cognito:groups" claim instead)