Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ test pipeline #193

Merged
merged 1 commit into from
May 29, 2024
Merged

⚡ test pipeline #193

merged 1 commit into from
May 29, 2024

Conversation

diegoluisi
Copy link
Contributor

Thank you for making Devxp Tech - Helm Charts better

Please reference the issue this PR is fixing.

Also verify you have:

@diegoluisi diegoluisi requested a review from a team as a code owner May 29, 2024 08:37
Copy link

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive.
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link

Charts Differences:

Changes in cluster-bootstrap:

Changes in devxp-app:

  - name: tcp-metrics					      <
    port: 9090						      <
    targetPort:  9090					      <
    protocol: TCP					      <
        - name: tcp-metrics				      <
          containerPort:  9090				      <
            port: 9090					      |	            port: 8080
            path: /actuator/health/liveness		      |	            path: /health-check/liveness
          initialDelaySeconds: 120			      |	          initialDelaySeconds: 10
            port: 9090					      |	            port: 8080
            path: /actuator/health/readiness		      |	            path: /health-check/readiness
          initialDelaySeconds: 120			      |	          initialDelaySeconds: 10
    - port: tcp-metrics					      |	    - port: tcp-node
      path: /actuator/prometheus			      |	      path: /metrics

Changes in devxp-dev:

Changes in devxp-infra:

Changes in tooling:

@diegoluisi diegoluisi merged commit 3448e00 into main May 29, 2024
4 checks passed
@diegoluisi diegoluisi deleted the hotfix/devxp-app/test-pipeline2 branch May 29, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant