Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency express to v4.20.0 [security] #267

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 28, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
express (source) 4.19.2 -> 4.20.0 age adoption passing confidence
express (source) 4.18.2 -> 4.20.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-43796

Impact

In express <4.20.0, passing untrusted user input - even after sanitizing it - to response.redirect() may execute untrusted code

Patches

this issue is patched in express 4.20.0

Workarounds

users are encouraged to upgrade to the patched version of express, but otherwise can workaround this issue by making sure any untrusted inputs are safe, ideally by validating them against an explicit allowlist

Details

successful exploitation of this vector requires the following:

  1. The attacker MUST control the input to response.redirect()
  2. express MUST NOT redirect before the template appears
  3. the browser MUST NOT complete redirection before:
  4. the user MUST click on the link in the template

CVE-2024-29041

Impact

Versions of Express.js prior to 4.19.2 and pre-release alpha and beta versions before 5.0.0-beta.3 are affected by an open redirect vulnerability using malformed URLs.

When a user of Express performs a redirect using a user-provided URL Express performs an encode using encodeurl on the contents before passing it to the location header. This can cause malformed URLs to be evaluated in unexpected ways by common redirect allow list implementations in Express applications, leading to an Open Redirect via bypass of a properly implemented allow list.

The main method impacted is res.location() but this is also called from within res.redirect().

Patches

expressjs/express@0867302
expressjs/express@0b74695

An initial fix went out with [email protected], we then patched a feature regression in 4.19.1 and added improved handling for the bypass in 4.19.2.

Workarounds

The fix for this involves pre-parsing the url string with either require('node:url').parse or new URL. These are steps you can take on your own before passing the user input string to res.location or res.redirect.

References

https://github.com/expressjs/express/pull/5539
https://github.com/koajs/koa/issues/1800
https://expressjs.com/en/4x/api.html#res.location


Release Notes

expressjs/express (express)

v4.20.0

Compare Source

==========

  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • Remove link renderization in html while redirecting
  • deps: [email protected]
    • add depth option to customize the depth level in the parser
    • IMPORTANT: The default depth level for parsing URL-encoded data is now 32 (previously was Infinity)
  • Remove link renderization in html while using res.redirect
  • deps: [email protected]
    • Adds support for named matching groups in the routes using a regex
    • Adds backtracking protection to parameters without regexes defined
  • deps: encodeurl@~2.0.0
    • Removes encoding of \, |, and ^ to align better with URL spec
  • Deprecate passing options.maxAge and options.expires to res.clearCookie
    • Will be ignored in v5, clearCookie will set a cookie with an expires in the past to instruct clients to delete the cookie

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Mar 28, 2024
Copy link
Contributor Author

renovate bot commented Mar 28, 2024

Branch automerge failure

This PR was configured for branch automerge. However, this is not possible, so it has been raised as a PR instead.

@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 6d71069 to fac9979 Compare March 28, 2024 22:49
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 3a12ded to ab95ec6 Compare April 6, 2024 02:33
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from 23088c6 to 32120cf Compare May 13, 2024 08:08
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 9a405f8 to 5079046 Compare May 21, 2024 11:07
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 4 times, most recently from fca98aa to 5878f3a Compare June 12, 2024 03:04
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 3 times, most recently from b0e0a6a to 05a036b Compare June 17, 2024 05:13
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from 8f26fb9 to d9ec2f6 Compare June 28, 2024 16:47
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 2 times, most recently from d7d5709 to adbf744 Compare July 16, 2024 06:40
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from adbf744 to 670a96d Compare September 17, 2024 17:05
@renovate renovate bot changed the title fix(deps): update dependency express to v4.19.2 [security] fix(deps): update dependency express to v4.20.0 [security] Sep 17, 2024
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from 670a96d to faa495c Compare September 21, 2024 10:17
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from faa495c to 76d9efd Compare October 4, 2024 02:20
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch 4 times, most recently from 8b87192 to a860242 Compare November 4, 2024 11:36
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from a860242 to ef15393 Compare November 5, 2024 04:07
@renovate renovate bot force-pushed the renovate/npm-express-vulnerability branch from ef15393 to 70cdf27 Compare November 15, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants