Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): new question types #446

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

feat(backend): new question types #446

wants to merge 43 commits into from

Conversation

KavikaPalletenne
Copy link
Contributor

Adds support for new question types:

  • short answer (existing impl changed)
  • multi-select
  • multi-choice
  • drop-down

Significantly changes API, so frontend must be updated to reflect this.

KavikaPalletenne and others added 30 commits February 2, 2023 14:07
@KavikaPalletenne
assign questions to one or all roles
3108842
@KavikaPalletenne
fix passing in reference to PgConnection
329287f
@KavikaPalletenne
Revert "fix passing in reference to PgConnection"
4fe45aa 
This reverts commit 329287f.
@KavikaPalletenne
added basic migration
5ff27d7 
down.sql doesn't recover data (cannot see which roles the original question was meant to be asked for, if it was asked for more than one role)
@KavikaPalletenne
feat(backend): changed questions to common or unique
809d1bf
@KavikaPalletenne
fix(backend): seed.rs updated to match new questions schema
2654217
@KavikaPalletenne
style: ran cargo fmt
e662319 
ran `cargo fmt` on `campaigns.rs` & `models.rs`
feat: add new file to accomodate future additions of new question typ…
334ddd6 
…es. Marked where to implement future chanes for Question and Answer. Added new AnswerInput struct
@KavikaPalletenne
Merge pull request #1 from KavikaPalletenne/main
5163b33 
fix(ci): run frontend ci for pull requests (#401)
Merge branch 'main' into CHAOS-204-new-question-types-framework
2aa0981 
fix: Update cli from main
feat: added migration for updating questions table to accomodate ques…
28a3b91 
…tion type field, updated campaign.rs for future implementations of inserting question data
feat: changed question type default from NULL to ShortAnswer, added s…
6908e41 
…ome stubs for querying question data
feat: changed Question Response to include question Data; added Data …
3ee61b7 
…for Answers as well, structred similar to Question; added function stubs to deal with inserting Answer Data; added migration for adding answer_type field to answer; changed schema of Answer
feat: changed answer endpoint to send AnswerResponse type (answer + d…
969d105 
…ata); added new error types for Application End point; added new functions for finding AnswerData from borrow of a Answer struct (did the same to QuestionDataEnum), changed some of tsome of the cases where originally question_id is used to find data into using borrow of the Question struct already found.
fix: merged updated main
b9f2907
fix:merge chaos-183
4e4ac04
@KavikaPalletenne
create migration to rename question_types enum
327d9a0 
Rename the enum to "question_type"
@KavikaPalletenne
create migration for new multi select-based question types
f94306c
@KavikaPalletenne
change answer_type to NOT NULL
1595e3d
@KavikaPalletenne
change question_type to NOT NULL
8ddc1f1
@KavikaPalletenne
updated schema.rs to reflect new question/answer types
ce1dc2d
@KavikaPalletenne
feat(backend): multiple-select question family stubs
c1d0212
@KavikaPalletenne
feat(backend): create new data types for question data input
05fbbf5
@KavikaPalletenne
feat(backend): handle insertion of question data into DB
508ccf8
@KavikaPalletenne
feat(backend): updated schema.rs to handle new question types
e230f5b
@KavikaPalletenne
feat(backend): insert and get question data from db
b181d33
@KavikaPalletenne
feat(backend): fix not searching for question using question id
13f0dfe
@KavikaPalletenne
feat(backend): answer and question data input/fetch
bad8666
@KavikaPalletenne
Merge branch 'CHAOS-208-multi-select-question-type' into CHAOS-204-ne…
86e7010 
…w-question-types-framework

# Conflicts:
#	backend/server/src/database/schema.rs
@KavikaPalletenne
feat(fix-partial): partially fixed returns and queries in new questio…
20da953 
…n/answer types
@KavikaPalletenne KavikaPalletenne requested a review from a team as a code owner July 21, 2023 11:28
@KavikaPalletenne
Copy link
Contributor Author

Hey team,

I hope you're all doing well! I'm excited to share with you a new pull request that enhances our platform's capabilities and brings some valuable improvements. This PR introduces support for new question types and includes essential changes to our API, which will require corresponding updates on the frontend to maintain seamless integration.

What's Included:

  • Short Answer (Existing Impl Changed): We've modified the implementation of the short answer question type to optimize its performance and make it more user-friendly.
  • Multi-Select: Now users can select multiple options from a list of choices when answering questions, providing a more flexible and interactive experience.
  • Multi-Choice: This new question type allows users to choose a single option from a list of choices, streamlining the assessment process.
  • Drop-Down: We've added support for drop-down menus as a question type, offering a more compact and organized way of presenting options.

API Changes:
The introduction of these new question types necessitated some significant changes to our API. As a result, we kindly request that the frontend team makes the necessary adjustments to ensure seamless compatibility with the backend.

How to Test:
To validate the changes, we have conducted extensive testing on various scenarios and datasets. We encourage all team members to review this PR and, if possible, test it on your local environments. Any feedback, suggestions, or bug reports are highly appreciated.

Impact on Existing Features:
Rest assured, we have taken great care to ensure backward compatibility with existing features. However, there might be some edge cases that we may have missed during testing. We'll be vigilant in addressing any issues that arise during the review process.

Contributor Recognition:
I want to extend my appreciation to everyone who contributed to this pull request. It showcases the collective talent and dedication of our team in striving for excellence.

Let's collaborate and get this feature integrated as soon as possible to enhance our platform's functionality and provide our users with a richer experience.

Thank you all for your support and hard work!

Best regards,
[Your Name]

AlexMIaoPU
AlexMIaoPU reviewed Jul 26, 2023
View reviewed changes
backend/server/src/database/models.rs Outdated Show resolved Hide resolved
backend/server/src/database/models.rs Outdated Show resolved Hide resolved
backend/server/src/database/models.rs Outdated Show resolved Hide resolved
backend/server/src/database/models.rs Outdated Show resolved Hide resolved
backend/server/src/database/models.rs Show resolved Hide resolved
backend/src/schema.rs Outdated Show resolved Hide resolved
backend/server/src/question_types.rs Outdated Show resolved Hide resolved
backend/server/src/question_types.rs Show resolved Hide resolved
backend/server/src/question_types.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexMIaoPU AlexMIaoPU AlexMIaoPU left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KavikaPalletenne @AlexMIaoPU