Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar #192

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Sidebar #192

wants to merge 6 commits into from

Conversation

johnfumaster
Copy link

Added sidebar and sidebarAndStepWrapper prop.
This will enable the consumer to implement a sidebar based off the steps rather than hard coding the steps in a separate sidebar component.

image

@AndersGerner
Copy link

This looks great! Looking forward to see this feature in the Repo :)

Copy link

@AndersGerner AndersGerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to give my thumbs up - I think it looks great :)

There are things that needs to be updated like existBeforeEnter on AnimatePresence, but that is out of scope for this PR. I would like to see this soon in the next version :)

@johnfumaster
Copy link
Author

johnfumaster commented May 29, 2024

Thanks @AndersGerner for the thumbs up. I haven't dug into the codebase long enough to know about the existBeforeEnter and AnimatePresence yet, but sounds like something I can do.

But until @devrnt approves the PR, I'm just patching the package in my project so I can use the steps. Also, when I was using it in my current project, I ended up not using the sidebarAndStepWrapper as I found it a bit messy to use. It felt like a hack. So instead, I used a grid layout as a wrapper to position the elements.

I considered removing the sidebarAndStepWrapper from this PR, but decided against it as others might find it useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants