-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar #192
base: main
Are you sure you want to change the base?
Sidebar #192
Conversation
Gives ability to add a wrapper around the sidebar and the active step. Useful for styling.
This looks great! Looking forward to see this feature in the Repo :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to give my thumbs up - I think it looks great :)
There are things that needs to be updated like existBeforeEnter on AnimatePresence, but that is out of scope for this PR. I would like to see this soon in the next version :)
Thanks @AndersGerner for the thumbs up. I haven't dug into the codebase long enough to know about the existBeforeEnter and AnimatePresence yet, but sounds like something I can do. But until @devrnt approves the PR, I'm just patching the package in my project so I can use the steps. Also, when I was using it in my current project, I ended up not using the I considered removing the sidebarAndStepWrapper from this PR, but decided against it as others might find it useful. |
Added sidebar and sidebarAndStepWrapper prop.
This will enable the consumer to implement a sidebar based off the steps rather than hard coding the steps in a separate sidebar component.