fix: correctly set the script translation text domain

devowlio · Jun 16, 2020 · cca32fe · cca32fe
1 parent 86c3d66
commit cca32fe
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/common/webpack.factory.ts b/common/webpack.factory.ts
@@ -348,6 +348,7 @@ function createDefaultSettings(
                 "process.env": definePlugin({
                     NODE_ENV: JSON.stringify(NODE_ENV),
                     env: JSON.stringify(NODE_ENV),
+                    rootSlug: JSON.stringify(rootPkg.name),
                     slug: JSON.stringify(slug)
                 })
             }),

diff --git a/packages/utils/src/Assets.php b/packages/utils/src/Assets.php
@@ -381,7 +381,7 @@ protected function enqueueComposer(
                 wp_enqueue_script($useHandle, $url, $deps, $cachebuster, $in_footer);
                 $this->setLazyScriptTranslations(
                     $useHandle,
-                    $useHandle,
+                    $rootSlug . '-' . $handle,
                     path_join($pluginPath, $packageDir . 'languages/frontend/json')
                 );
             } else {

diff --git a/packages/utils/src/PackageLocalization.php b/packages/utils/src/PackageLocalization.php
@@ -24,7 +24,7 @@ class PackageLocalization {
      * @param string $packageDir Absolute path to your package.
      * @codeCoverageIgnore
      */
-    private function __construct($rootSlug, $packageDir) {
+    protected function __construct($rootSlug, $packageDir) {
         $this->rootSlug = $rootSlug;
         $this->packageDir = $packageDir;
     }