Dev/version1 #66
Merged
Dev/version1 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
plz provide a description for your pr following semantic versioning, |
|
Certainly, there is no issue i tried to solve. I've just added a simple
script for some automation as I added in the description
…On Wed, 16 Oct 2024 at 13:52, Shayan Ghani ***@***.***> wrote:
plz provide a description for your pr following semantic versioning,
link the issue you're trying to solve
—
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS7FPEMULLSPVXTRDAXF4KLZ3Y46VAVCNFSM6AAAAABQAX6GVCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJWGM3TONRQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Alright, LGTM but next time start your pr description in the following way: fix Vagrant and virtualbox installation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to automate the vagrant and virtual box installation by adding a simple script in the scripts folder and triggering it at the start.sh