Use String as id for Storable #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.39%@@ master #78 diff @@
==========================================
Files 9 9
Lines 435 435
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 428 428
Misses 7 7
Partials 0 0
|
|
Will merge it for the moment as I need the changes, we cans till discuss later and eventually revert if you don't agree. |
| // TODO: default to String and create a protocol that as an Int id with default implementation. Because String is not always convertible to Int but Int can always be converted to String. | ||
| var id: Int { get } | ||
| init(id: Int, db: KakapoDB) | ||
| /// The unique identifier provided by `KakapoDB`, objects shouldn't generate ids themselves. `KakapoDB` generate `Int` ids converted to String for better compatibilities with standards like JSONAPI, in case you need `Int` ids is safe to ssume that the conversion will always succeeed. |
There was a problem hiding this comment.
I think we could provide an example with Int identifiers here.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26
Rationale:
mpow [5:24 PM]
FYI just implemented id as String instead of Int otherwise JSONAPIEntity can't be easily Storable, the id generated by db will still be Int converted to String. This is better because Int is always convertible to string but not the other way around
(docu missing, waiting for merge of docu PR)