Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch: add ntfs-3g #345

Merged
merged 1 commit into from
Feb 23, 2024
Merged

switch: add ntfs-3g #345

merged 1 commit into from
Feb 23, 2024

Conversation

DarkMatterCore
Copy link
Contributor

Based on the original PKGBUILD script + patch from the libusbhsfs repository, plus some extra modifications based on the PPC portlib.

References:

Based on the original PKGBUILD script + patch from the libusbhsfs repository, plus some extra modifications based on the PPC portlib.

References:

* devkitPro/docker#28
* https://devkitpro.org/viewtopic.php?p=17868
@WinterMute WinterMute merged commit 9e9bc13 into devkitPro:master Feb 23, 2024
@DarkMatterCore
Copy link
Contributor Author

It seems like the package generated by this build script isn't getting fully populated. After running pacman -S switch-ntfs-3g and checking /opt/devkitpro/portlibs/switch, only the NTFS-3G license is getting installed.

I'll look into the issue.

@WinterMute
Copy link
Member

Heh, I didn't check the package contents, sorry. The PKGBUILD was missing the install step & it looks like that bit of the patch I thought wasn't necessary probably was. I've rebuilt the package, should be fine now.

@DarkMatterCore
Copy link
Contributor Author

Heh, I didn't check the package contents, sorry. The PKGBUILD was missing the install step & it looks like that bit of the patch I thought wasn't necessary probably was. I've rebuilt the package, should be fine now.

Thanks! I appreciate it.

Btw, I also noticed we're not copying the config.h file that gets generated during the NTFS-3G build steps. I created an additional PR to address that: #347

Hope that helps.

@averne
Copy link
Contributor

averne commented Mar 7, 2024

@WinterMute Would you be accepting PKGBUILDs for libnfs and libsmb2 as well? I have those on my tree but never tried to upstream them, since the team's standing seemed to be that filesystem implementations should live in sysmodules.

In the case of libsmb2, there is also an old PR that went inactive since readv and writev are not provided by newlib. Atomicity can be achieved by just copying the data to a single buffer and sending that over. Not pretty of course but this is what glibc does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants