initial import of vector_generic (non-simd) support #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issues revolving around simd compilation definitions
ct-clmsn
changed the title
ct-clmsn
changed the title
| part = strtoi(ptno, pos, 16); | ||
|
|
||
| // part = strtoi(ptno, pos, 16); | ||
| auto ptno_substr = ptno.substr(pos, 16); |
There was a problem hiding this comment.
Why the substr? To prevent overflow?
|
@ct-clmsn thanks for the PR. It looks like indeed I haven't merged back the ARM NEON changes I made to MArray for use in CFOUR. Let me do that, and then please resubmit the PR to https://github.com/devinamatthews/marray. Re TBLIS, the master branch is defunct and a new version is coming shortly. I'll try to incorporate some of the other changes there. |
|
Actually, https://github.com/devinamatthews/marray is up-to-date on the NEON stuff, it's just the TBLIS version which is behind. |
|
Cool; so we'll close this one and I'll move the PR over to the marray project tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding support for non-simd vectors