LibWeb: Always return a KeyAlgorithm from RsaHashedKeyAlgorithm

The spec never mentions the possibility for the `hash` member of `RsaHashedKeyAlgorithm` to be a string, it should be a `KeyAlgorithm` object containing a `name` string member. Spec: https://w3c.github.io/webcrypto/#dfn-RsaHashedKeyAlgorithm
devgianlu · Jan 17, 2025 · 159ba4f · 159ba4f
1 parent 1ac4151
commit 159ba4f
Show file tree

Hide file tree

Showing 4 changed files with 529 additions and 528 deletions.
diff --git a/Libraries/LibWeb/Crypto/KeyAlgorithms.cpp b/Libraries/LibWeb/Crypto/KeyAlgorithms.cpp
@@ -179,7 +179,10 @@ JS_DEFINE_NATIVE_FUNCTION(RsaHashedKeyAlgorithm::hash_getter)
     auto hash = TRY(Bindings::throw_dom_exception_if_needed(vm, [&] { return impl->hash(); }));
     return hash.visit(
         [&](String const& hash_string) -> JS::Value {
-            return JS::PrimitiveString::create(vm, hash_string);
+            auto& realm = *vm.current_realm();
+            auto object = KeyAlgorithm::create(realm);
+            object->set_name(hash_string);
+            return object;
         },
         [&](GC::Root<JS::Object> const& hash) -> JS::Value {
             return hash;