fix: don't seek to the start when swiping right #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API has an extra parameter `allow_seeking` that indicates whether the seek left is due to pressing the "prev" button, or because the album is swiped right to go to the previous track immediately. This patch adds support for this feature. There's still one issue however: when going to the previous song, the player will for a short time show the first track in an album. Not sure why, I suspect go-librespot doesn't send the whole queue (so the player doesn't know there are other tracks in the album).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API has an extra parameter
allow_seekingthat indicates whether the seek left is due to pressing the "prev" button, or because the album is swiped right to go to the previous track immediately.This patch adds support for this feature.
There's still one issue however: when going to the previous song, the player will for a short time show the first track in an album.
Not sure why, I suspect go-librespot doesn't send the whole queue (so the player doesn't know there are other tracks in the album).see #113 for a fix to this bug.