Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise client name RHTAP to Konflux #310

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

michael-valdron
Copy link
Member

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Changes the client name RHTAP to Konflux in client tests and documentation.

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@michael-valdron michael-valdron requested a review from a team February 29, 2024 21:31
@openshift-ci openshift-ci bot requested review from Jdubrick and thepetk February 29, 2024 21:31
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Feb 29, 2024
Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member Author

/hold

Needs openshift/release#49400 to be merged.

Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron
Copy link
Member Author

/hold

Needs openshift/release#49400 to be merged.

/unhold

Actually this should be merged before openshift/release#49400 can be.

@Jdubrick
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Mar 14, 2024
@michael-valdron michael-valdron merged commit b9b72a1 into devfile:main Mar 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants