Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample versions in extraDevfileEntries.yaml #254

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Nov 30, 2023

What does this PR do?:

This PR is the last step to the support of multiple sample versions inside the extraDevfileEntries.yaml. This feature will allow us to support samples with parents using outerloop and to have more consistent ports.

As a result all entries inside the extraDevfileEntries.yaml have been updated to have versions. Other than that the 3 samples that have a parent supporting outerloop now have an extra version. Those are:

  • go-basic: We have added version 2.0.0 in order to support the outerloop go stack versions.
  • python-basic: We have added version 2.0.0 in order to support the outerloop python stack versions.
  • java-springboot-basic: We have added version 2.0.0 in order to support the outerloop java-springboot stack versions.

Which issue(s) this PR fixes:

fixes devfile/api#1112

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Some notes for the consumers of the registry:

  • ODC is using the /index/sample endpoint which will only return the default (old) versions of each sample.
  • RHTAP is using the /index/sample endpoint which will only return the default (old) versions of each sample.
  • odo is not using the devfile samples.

For RHTAP I've tried to update locally the mock-devfile-data.ts with the updated index/sample (only the git.revision is added) and ran the tests. The tests were ok.

For ODC I've started a console server locally (CRC) using minikube & a build of the updated registry.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Nov 30, 2023
Copy link

openshift-ci bot commented Nov 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 92c2514 into devfile:main Dec 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Devfile Samples to reference v2.2.0 Parent stacks
2 participants