Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new sample versions for sample with parent outerloop support #1360

Closed
3 tasks done
thepetk opened this issue Nov 27, 2023 · 1 comment
Closed
3 tasks done

Create new sample versions for sample with parent outerloop support #1360

thepetk opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@thepetk
Copy link
Contributor

thepetk commented Nov 27, 2023

Which area/kind this issue is related to?

/area registry

Issue Description

This Issue is part of the #1112, which was split in order to track better the progress of the multiple sample versions support. This issue focuses on the creation of new sample versions for each one of the samples that have a parent which supports outerloop. Those samples are:

  • python-basic
  • java-springboot-basic
  • go-basic

Every new version will have the 2.0.0 value and will be on a different branch (e.g. v2.0.0 branch for go-basic:2.0.0) and will use port 8080 instead of 8081 in order to be more consistent.

In order to keep backwards compatibility with ODC and RHTAP we will have to maintain the default version of every sample in the main (default) branch. This is the reason why we will have to create a new branch for the new version.

Acceptance Criteria

  • New version (2.0.0) is created for go-basic, python-basic and java-springboot basic samples.
  • New versions are merged inside a different branch (v2.0.0) and not the default one.
  • New versions are using the 8080 port instead of 8081.
@thepetk
Copy link
Contributor Author

thepetk commented Nov 28, 2023

Closing as all of the related PRs have been merged. Now all samples that have a parent supporting outerloop have a new version (python-basic, go-basic, springboot-basic)

@thepetk thepetk closed this as completed Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
Status: Done ✅
Development

No branches or pull requests

1 participant