-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create version 2.0.0 for go-basic sample #29
Conversation
As discussed during standup, you could move the commands into the parent declaration, so they will override the parent's ones |
90ae33b
to
1f6c669
Compare
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
This reverts commit 6ef2b43.
bce8564
to
0900694
Compare
@thepetk I think we discussed this a bit on the call, but do we want to also merge the port update changes with your branch? #26 will help with https://issues.redhat.com/browse/DEVHAS-423 |
Signed-off-by: thepetk <[email protected]>
@maysunfaisal I've added the update of the port from 8081 to 8080 |
Signed-off-by: thepetk <[email protected]>
Has this change be tested on ODC, odo and HAS to ensure the port update won't cause any regression? |
@yangcao77 I think is a good idea to test all new versions on those consumers :) |
@thepetk Since we only have one version for all samples currently, any change to samples will directly affect all consumers. plus no ci tests running for samples neither. so it's a requirement to test out before any sample update. |
@yangcao77 yup totally agree. One question I have is if we need to update the contributing here https://github.com/devfile/registry/blob/main/CONTRIBUTING.md#samples to include those checks too? Finally just to clarify, atm all the new version PRs will be merged on different branches than |
Signed-off-by: thepetk <[email protected]>
signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
@maysunfaisal port is now 8080 for the new sample version. Feel free to review! |
What does this PR do?:
This PR creates a new version of
go-basic
sample. The new version uses the2.1.0
version ofgo
stack instead of the default one1.0.2
.Which issue(s) this PR fixes:
fixes devfile/api#1360