Provide progress parameter via fold pending parameter #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2018
Merged
raveclassic
suggested changes
Oct 24, 2018
src/remote-data.ts
Outdated
| fold<B>(initial: B, pending: B, failure: Function1<L, B>, success: Function1<A, B>): B { | ||
| fold<B>( | ||
| initial: B, | ||
| pending: Function1<Option<RemoteProgress>, B>, |
There was a problem hiding this comment.
This is a massive breaking change. Would foldL be enough for you?
There was a problem hiding this comment.
Sure I can split the changes and provide the breaking change in a separate pull request?
There was a problem hiding this comment.
Well the problem is actually deeper. If we start processing pendings with functions then we should also change pending helper which immediately turns out to be the same as progress. Smth one should be left.
/cc @sutarmin @OliverJAsh
This may be a single PR for the next breaking 0.4 version together with #5
|
@raveclassic something missing? |
|
@mlegenhausen sorry, slipped my mind :) |
raveclassic
approved these changes
Oct 29, 2018
|
@raveclassic thanks |
mlegenhausen
pushed a commit
to werk85/remote-data-ts
that referenced
this pull request
Oct 29, 2018
raveclassic
pushed a commit
that referenced
this pull request
Nov 6, 2018
raveclassic
pushed a commit
that referenced
this pull request
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.