Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add progress to RemotePending #13

Merged
merged 5 commits into from
Sep 24, 2018
Merged

feat: Add progress to RemotePending #13

merged 5 commits into from
Sep 24, 2018

Conversation

raveclassic
Copy link
Contributor

closes #9

@raveclassic raveclassic mentioned this pull request Sep 21, 2018
Closed
OliverJAsh
OliverJAsh approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@OliverJAsh OliverJAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I won't be needing the concat functionality, it's good you've thought about it. Nice work!

sutarmin
sutarmin reviewed Sep 22, 2018
View reviewed changes
src/remote-data.ts Outdated
};
const concatPendings = <L, A>(a: RemotePending<L, A>, b: RemotePending<L, A>): RemotePending<L, A> => {
const noA = a.progress.isNone();
const noB = b.progress.isNone();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these declarations could be moved closer to the place where they are used at.

@raveclassic
Copy link
Contributor Author

raveclassic commented Sep 24, 2018 •
edited
Loading

@OliverJAsh Looks like I forgot to update getSemigroup, thanks for mentioning concat :)

@raveclassic raveclassic merged commit 8b14c3d into master Sep 24, 2018
@raveclassic raveclassic deleted the feature/add-progress-to-remote-pending branch September 24, 2018 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutarmin sutarmin sutarmin approved these changes

@OliverJAsh OliverJAsh OliverJAsh approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add progress to RemotePending
3 participants
@raveclassic @OliverJAsh @sutarmin