Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the path to the modern bundle in the example in README.md #1086

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlshv
Copy link

@mlshv mlshv commented Aug 5, 2024

In the example path to modern bundle ends with .js, but microbundle generates .mjs file

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: a67aa8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rschristian
Copy link
Collaborator

rschristian commented Aug 5, 2024

That example has "type": "module" which means it should be generated as .js actually (let me know if it isn't on your end). It should be correct as-is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants