Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[schema] Add lifecycle hooks to devContainerFeature #207

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

joshspicer
Copy link
Member

@joshspicer joshspicer requested a review from a team as a code owner March 3, 2023 19:20
@joshspicer joshspicer changed the title Add lifecycle hooks to devContainerFeature schema [schema] Add lifecycle hooks to devContainerFeature Mar 3, 2023
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments. LGTM otherwise.

schemas/devContainerFeature.schema.json Outdated Show resolved Hide resolved
schemas/devContainerFeature.schema.json Outdated Show resolved Hide resolved
@joshspicer joshspicer requested a review from chrmarti March 9, 2023 18:25
Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@joshspicer joshspicer merged commit 15f30fd into main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants